[SYCLomatic] Support migration for cub::{StoreDirectBlocked, StoreDirectStriped} API #1305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihanwg
reviewed
Sep 18, 2023
yihanwg
reviewed
Sep 18, 2023
yihanwg
reviewed
Sep 18, 2023
yihanwg
reviewed
Sep 18, 2023
yihanwg
reviewed
Sep 19, 2023
yihanwg
reviewed
Sep 19, 2023
yihanwg
reviewed
Sep 19, 2023
abhilash1910
changed the title
|
Linked to #2094 |
yihanwg
reviewed
Jul 24, 2024
yihanwg
reviewed
Aug 13, 2024
yihanwg
suggested changes
Aug 13, 2024
clang/lib/DPCT/APINames_CUB.inc
Outdated
| @@ -124,7 +123,6 @@ ENTRY_MEMBER_FUNCTION(cub::BlockShuffle, cub::BlockShuffle, Rotate, Rotate, fals | |||
| ENTRY_MEMBER_FUNCTION(cub::BlockShuffle, cub::BlockShuffle, Up, Up, false, NO_FLAG, P4, "Comment") | |||
| ENTRY_MEMBER_FUNCTION(cub::BlockShuffle, cub::BlockShuffle, Down, Down, false, NO_FLAG, P4, "Comment") | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Let's remove extra blank line change.
|
Can you merge this PR into #1819? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Migration of cub::store API . Linked to #1819
cc @yihanwg , @zhimingwang36